[FFmpeg-devel] [PATCH] mdec.c cleanups

Michael Niedermayer michaelni
Fri Jun 27 13:04:43 CEST 2008

On Thu, Jun 26, 2008 at 10:03:56PM -0400, Alexander Strange wrote:
> Inspired by Michael's psxstr cleanup.
> 1- Use reget_buffer().

rejected, this might cause issues with double buffering and such, i wont
accept this without an explanation of why it should be changed. Also moving
reference afterwards is incorrect

> 2- Move setting the three different ways of being a keyframe into 
> decode_init, since they never change.

rejected, i see no sense in this they should be set where the pic is allocated
and they are

> 3- Remove unused PutBitContext since there's no encoder, and probably won't 
> be one.


> 4- Fix and uncomment the code setting qscale_table.

ok if it has been tested and works (postprocessing looks better)

> 5- Remove commented-out code.


> 6- Remove pointless emms_c(). Several other codecs have these lying around 
> too.


> 7- Remove pointless casting to AVFrame*.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080627/9f7849d0/attachment.pgp>

More information about the ffmpeg-devel mailing list