[FFmpeg-devel] [PATCH] make img_convert symbol conditional on lavc version, not libswscale

Michael Niedermayer michaelni
Wed Jun 25 13:27:57 CEST 2008

On Wed, Jun 25, 2008 at 01:02:30PM +0200, Reinhard Tartler wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> > Ok when you ask so nicely, patch strongly rejected!
> >
> > If you want to do fix the scaler issue, drop the old API which is deprecated
> > since ages. The old scaler can be used through the new API.
> The request is to reenable the old scaler using the old API with
> --enable-swscale.
> You objected previously that it would only 'bloat' the library. Diegos
> patch now makes this conditionally, so this concern is adressed. I
> therefore don't understand why you still object this. Could you perhaps
> elaborate on the reason why you object here?

My objection is that it bloats the lib, causes us work, does not move
ffmpeg forward and may lead to all kinds of obscure bugs. The code has
not been designed with the consideration that both scalers might be enabled
at the same time.

If we drop the old API everyone is forced to switch to the new one.
If we add support for both scalers
    code would be twice as large
    we would possibly have to deal with weird bugs
    we would have to spend considerable time reviewing both scalers to ensure
        they dont conflict in obscure ways
    and in the end everyone still would have to switch to the new API

-> so this patch is strictly more work for us as well as everyone at average
   than droping the old API.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080625/0046a8ec/attachment.pgp>

More information about the ffmpeg-devel mailing list