[FFmpeg-devel] [PATCH] Fix mm_flags, mm_support for ARM

[Michael Niedermayer]

On Wed, Jun 25, 2008 at 10:47:06AM +0200, Laurent Desnogues wrote:
> Hello,
> 
> here is a quick fix for mm_flags/mm_support for ARM that enables
> compilation of dct-test.
> 
> I moved mm_flags from dsputil_iwmmxt.c to dsputil_arm.c and
> defined mm_support as 0 in dsputil.h.
> 
> The rationale for moving mm_flags to dsputil_arm.c is that this
> will be used when NEON support is added, so I think it makes
> sense to "factor" it.
> 
> For mm_support, I would like to make it sensible, but that
> workaround should be OK for now.
> 
> As usual, noobness warning applies :-)

I do not like the patch, mm_support()=0 is wrong and mm_flags is just
redundant, the code can as well use HAVE_IWMMXT until proper 
runtime cpu detect is added for ARM.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080625/36d0ae36/attachment.pgp>