[FFmpeg-devel] [PATCH] Cleaner parity checking code in mlp_parser.c

Ramiro Polla ramiro
Wed Jun 25 01:54:46 CEST 2008

Ramiro Polla wrote:
> Michael Niedermayer wrote:
>> On Tue, Jun 24, 2008 at 08:48:08PM +0100, Ramiro Polla wrote:
>>> Hello,
>>> In http://article.gmane.org/gmane.comp.video.ffmpeg.devel/59805 
>>> Michael suggested a way to minimize the code that does parity 
>>> checking on mlp_parser.c. This leads to the code being harder to 
>>> understand.
>>> The for() loop deals with the substream headers, and the smaller code 
>>> parity checked the access unit header in the same loop. It is 
>>> confusing since it looks like the loop is only doing the parity check 
>>> on the substream headers, and not on the access unit header. It takes 
>>> closer inspection to see that the access unit header is also being 
>>> checked.
>>> Is attached patch ok to desimplify the code to make it easier to 
>>> understand?
>> iam slightly against the patch
> Then what about your original idea on that thread? A -1 in there already 
> helps a bit in understanding the code is not only dealing with substream 
> headers.

And here's a patch for the Ministry of English Composition to clarify 
the comment about the code.

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parity_comment.diff
Type: text/x-diff
Size: 636 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080625/1c436d87/attachment.diff>

More information about the ffmpeg-devel mailing list