[FFmpeg-devel] One memory leakage in AAC/AC3 parser in ffmpeg

[Michael Niedermayer]

On Tue, Jun 24, 2008 at 10:25:10AM +0200, David LIU wrote:
> -----Original Message-----
> From: ffmpeg-devel-bounces at mplayerhq.hu
> [mailto:ffmpeg-devel-bounces at mplayerhq.hu] On Behalf Of Michael Niedermayer
> Sent: Thursday, June 19, 2008 11:26 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] One memory leakage in AAC/AC3 parser in ffmpeg
> 
> On Thu, Jun 19, 2008 at 11:01:31AM +0200, David LIU wrote:
> >> > From: ffmpeg-devel-bounces at mplayerhq.hu
> >> [mailto:ffmpeg-devel-bounces at mplayerhq.hu] On Behalf Of Michael 
> >> Niedermayer
> >> > Sent: Thursday, June 19, 2008 10:39 AM
> >> > To: FFmpeg development discussions and patches
> >> > Subject: Re: [FFmpeg-devel] One memory leakage in AAC/AC3 parser in 
> >> > ffmpeg
> >> 
> >> > On Thu, Jun 19, 2008 at 09:34:00AM +0200, David LIU wrote:
> >> >> On Wed, Jun 18, 2008 at 11:58:02AM +0200, David LIU wrote:
> >> >> >> Hi,
> >> >> >> 
> >> >> >> Please review patch and let me know reject or accept
> >> >> >> 
> >> >> >> Best regards
> >> >> 
> >> >> [...]
> >> >> 
> >> >> >> (Also avoid top-posting.)
> >> >>    ^^^^^^^^^^^^^^^^^^^^^^^
> >> >> 
> >> >> >besides that, ff_parse_close() should be used not a new redundant 
> >> >> >function
> >> >> added.
> >> >> 
> >> >> [David]: There is ParseContext type in ff_parse_close(). I have to 
> >> >> use AACAC3ParseContext type and that's why I create new
> ff_parse_close2().
> >> 
> >> > AACAC3ParseContext contains a ParseContext, move it to the top and
> >> AACAC3ParseContext is a ParseContext
> >> 
> >> [David]: This is correct and I agree your opinion then we can share 
> >> ff_parse_close(). My question is who and when will apply this patch if 
> >> you think this patch is useful.
> 
> >When we do have a patch that passes review it will be approved and applied
> eventually. ATM we just have one which adds a redundant function namely
> >ff_parse_close2()
> 
> >[...]
> 
> Please review the patch I updated.

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080624/bdafb3fd/attachment.pgp>