[FFmpeg-devel] [PATCH] Make ffserver print each launched commandline just before to launch them

Stefano Sabatini stefano.sabatini-lala
Mon Jun 23 22:50:43 CEST 2008


Hi all,
currently ffserver in debug-mode prints the launched commandlines just
when parsing the configuration file.

This way, if the user enables no-launch mode the launching commandline
messages are issued but the commandlines are indeed not launched, which
is misleading.

The attached patch fixes the problem, simply moving the code which
prints the commandline in the start_children() function.

Note that the code which computes the pathname is moved before the
code which closes all the file descriptors (including that for the
logfile).

Also this patch makes the launched commandlines be printed by
http_log() (ergo on stderr) rather than on stderr, as this seems to me
the correct behaviour, let me know if you prefer this fix into a
separate patch.

And maybe it would be also a good idea always print this information
on the logfile, not only in debug-mode.

Regards.
-- 
FFmpeg = Forgiving and Furious Mega Portentous Elitist Gorilla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: print-launch-in-start-children-00.patch
Type: text/x-diff
Size: 2071 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080623/9887c0a8/attachment.patch>



More information about the ffmpeg-devel mailing list