[FFmpeg-devel] [PATCH] AAC Decoder - Round 2.

[Robert Swain]

2008/6/20 Michael Niedermayer <michaelni at gmx.at>:
> On Thu, Jun 19, 2008 at 04:22:57PM +0100, Robert Swain wrote:
> [...]
>> +        case ID_CPE:
>> +            err = !ac->che[ID_CPE][tag] ? -1 : decode_cpe(ac, &gb, tag);
>> +            break;
>> +        case ID_FIL:
>> +            if (tag == 15) tag += get_bits(&gb, 8) - 1;
>> +            while (tag > 0)
>> +                tag -= extension_payload(ac, &gb, tag);
>> +            err = 0; /* FIXME */
>> +            break;
>> +        case ID_PCE:
>> +            err = program_config_element(ac, &gb);
>> +            break;
>> +        case ID_DSE:
>> +            err = data_stream_element(ac, &gb, tag);
>> +            break;
>> +        case ID_CCE:
>
>> +            err = !ac->che[ID_CCE][tag] ? -1 : decode_cce(ac, &gb, tag);
>> +            break;
>> +        case ID_LFE:
>> +            err = ac->che[ID_LFE][tag] && !decode_ics(ac, &gb, 0, 0, &ac->che[ID_LFE][tag]->ch[0]) ? 0 : -1;
>
> maybe iam too tired but these appear hard to read, maybe a if() and some \n
> would help

Does the attached help at all? If you don't want the ternary code
changing to if() else then just the \n between each case seems to help
me.

Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20080621-2130-switch_readability.diff
Type: text/x-diff
Size: 2023 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080621/e9ae3c0e/attachment.diff>