[FFmpeg-devel] [PATCH] movenc.c fix (Was: Can av_write_frame() modify pkt.data?)

Luca Abeni lucabe72
Thu Jun 19 09:12:02 CEST 2008

Hi Michael,

Michael Niedermayer wrote:
>>> Iam not sure if its the best either ... maybe we should change
>>> ff_avc_parse_nal_units to take a ByteIOContext ...
>>> Of course only if it would end up simpler, if its not simpler than
>>> your patch here is ok
>> Ok; this afternoon I'll try to have a look at passing a ByteIOContext as an
>> argument (but first I have to understand why this can simplify things ;-).
> writing straight vs. writing into a buffer, checking that something was
> written and then put_buffer it ...

Ok; I was looking at the wrong place ;-) (I started by looking at the impact
of this change on ff_isom_write_avcc()).

I now see how your idea can simplify the code. Unfortunately, I got
sidetracked by some other issues, and I've not been able to test these
changes. I attach a patch, to show how the final result will look like,
but be aware that the patch is only compile-tested.
I am not sure I like the way I changed ff_isom_write_avcc()... I'll have
to think about it a little bit more.

I'll probably have a tested patch next week.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-muxers-that-realloc-modify-pkt-data.patch
Type: text/x-diff
Size: 8004 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080619/27303d52/attachment.patch>

More information about the ffmpeg-devel mailing list