[FFmpeg-devel] [PATCH] AAC decoder

Michael Niedermayer michaelni
Fri Jun 13 13:14:00 CEST 2008

On Fri, Jun 13, 2008 at 11:17:51AM +0100, Robert Swain wrote:
> 2008/6/12 Michael Niedermayer <michaelni at gmx.at>:
> > [...]
> >> +        for(j=0; j<4; j++) {
> >> +        if (ac->che[j][i]) {
> >> +            sce_trans(ac, &ac->che[j][i]->ch[0]);
> >> +        if (j == ID_CPE)
> >> +            sce_trans(ac, &ac->che[j][i]->ch[1]);
> >
> > more odd indention
> The strange looking indentation is for lines of code that I altered I
> left them at the same level of indentation to avoid mixing cosmetic
> and functional changes. Is this what is wanted or if I edit lines, do
> you want me to alter their indentation to be correct in the same
> commit?

If you edit a line due to a functional change, please also fix its indention.
Only otherwise unchanged lines should be reindented in a seperate commit.

That not only makes the reindent patch smaller, it also makes the functional
changes patch easier to read as it is mostly correctly indented.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080613/55c0ef43/attachment.pgp>

More information about the ffmpeg-devel mailing list