[FFmpeg-devel] [PATCH] Make ffmpeg.c:opt_thread_count use parse_number_or_die()

Michael Niedermayer michaelni
Tue Jun 10 20:12:34 CEST 2008


On Tue, Jun 10, 2008 at 12:26:53AM +0200, Stefano Sabatini wrote:
> On date Thursday 2008-06-05 00:00:28 +0200, Stefano Sabatini encoded:
> > Hi,
> > as in subject, consistent with ffplay.c.
> 
> Hi, patch updated against latest SVN and ping
> 
> BTW, there are three patch against ffmpeg.c already oked by Michael,
> please can someone check and apply them, it's getting more and more
> painful to keep my working tree from becoming a total mess.
> 
> Or still better Michael let me have write permission, if you don't

fine, ok, but please dont randomly commit stuff unless some developer
reviewed and approved the change and the code has been tested! 
Some of your patches are nice but other are well ... :)
Also read our development/svn policy, people with svn accounts are
supposed to agree with it.


> trust me I can give you privately my real-life address and you can
> send to me Mans with his shotgun if I dare to apply something you
> didn't approved before ;-).

iam not interrested in your address

patch ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080610/b8f9aa6c/attachment.pgp>



More information about the ffmpeg-devel mailing list