[FFmpeg-devel] [PATCH] Get rid of p

Michael Niedermayer michaelni
Sun Jun 8 22:17:14 CEST 2008

On Sun, Jun 08, 2008 at 10:09:52PM +0200, Michael Niedermayer wrote:
> On Sun, Jun 08, 2008 at 08:57:21PM +0100, Ramiro Polla wrote:
> > > we can discuss the renaming then seperately ...
> > > iam not sure if its good or not for the functions in your patch ...
> > 
> > I know my argumentation skills are close to NULL, but I'll try anyways...
> > 
> > Once you know what the function does, having small variable names might 
> > be better, but if you're reading it for the first time to try and find 
> > out what it does, having single-letter or non-descriptive names makes it 
> > harder to understand. Or if you're debugging and stumble upon those 
> > variables, it takes longer to find out what they actually are.
> > 
> > I use FFmpeg's source code as a basis to learn lots of things. I prefer 
> > learning from well-written C code than textual descriptions like 
> > textbooks or tutorials, and I'm probably not the only one.
> > 
> > Another reason is that searching for any of occurrence of some variable 
> > becomes hard, since its name is part of many other variable names and 
> > mostly anything.
> get cscope

and a simple search for [^a-z]s[^a-z] looks pretty darn accurate for finding
all and only them

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080608/81ac9356/attachment.pgp>

More information about the ffmpeg-devel mailing list