[FFmpeg-devel] [PATCH/RFC] honor DAR aspect ratio in nuv files.

[Michael Niedermayer]

On Sat, Jun 07, 2008 at 03:06:28PM +0200, elupus wrote:
> > 
> > Don't think so. It was always hardcoded to be 1.0 in the muxer. And this is
> > the way myth's own player parses the value. 
> > 
> > However i'm leaning at not even setting sample_aspect_ratio when aspect is
> > 1.0, since apperently they never set any proper value for this. And by not
> > setting it, player will respect any aspect that can be deduced from the
> > contained mpeg2/4 stream. What do you think?
> 
> Anyway, here is a updated patch that behavies just like official myth
> player (and actually works). It considers a value of 1.0, which the old
> muxers wrote, a DAR of 4:3. 
[...]
> +        av_reduce(&vst->codec->sample_aspect_ratio.num,
> +                  &vst->codec->sample_aspect_ratio.den,
> +                  height * aspect,
> +                  width, 255);

this is wrong
converting height * aspect to an integer is nonsense

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080607/ceda8532/attachment.pgp>