[FFmpeg-devel] [PATCH] add ME_T/ESA to avcodec.h

Michael Niedermayer michaelni
Sat Jun 7 05:09:03 CEST 2008

On Sat, Jun 07, 2008 at 04:50:01AM +0200, Michael Niedermayer wrote:
> On Fri, Jun 06, 2008 at 07:25:24PM -0700, Baptiste Coudurier wrote:
> [...]
> > 2) adding a way to override AVOptions range for qmax etc.. which needs
> > to be hardcoded because user has no business saying that qmax max value
> > for mpeg-2 is 7821637. 
> true
> > Mainly because bumping default max value to 1024
> > would require every codec supporting qmax to check if value is valid.
> I see the problem, i dont know which solution is best but

besides the qmax max is 51 currently only h264 allows that, all the mpeg/h263
based ones end at 31 so they are alraedy missing checks ...
the bump to 1024 would only affect x264 in the "missing check" sense.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080607/872b0eea/attachment.pgp>

More information about the ffmpeg-devel mailing list