[FFmpeg-devel] [PATCH] add ME_T/ESA to avcodec.h

Robert Swain robert.swain
Sat Jun 7 04:34:21 CEST 2008

2008/6/7 Baptiste Coudurier <baptiste.coudurier at smartjog.com>:
> Michael Niedermayer wrote:
>> I really think you guys are going in the completely wrong direction
>> here
>> adding code duplication to _avoid_ supporting a usefull feature.>
> Well, I don't think Robert really explained correctly what I meant.

How dare you?! I'll gouge out your eyes with a rusty spoon and eat
your fingers with feta cheese and vinaigrette! ;)

> There are 2 separate issues:
> 1) replacing -target dvd/svcd/whatever (adding ipod), which VERY WELL
> fits in presets in homedir

Agreed. Michael, you should commit your code even if it is only used
for presets and not defaults as well.

> 2) adding a way to override AVOptions range for qmax etc.. which needs
> to be hardcoded because user has no business saying that qmax max value
> for mpeg-2 is 7821637. Mainly because bumping default max value to 1024
> would require every codec supporting qmax to check if value is valid.

Yes, I failed to communicate this. My patches pave the way for doing
this even if it doesn't end up being used for per codec defaults in
the preset sense.


PS - Yes, I know I'm silly and I enjoy it.

More information about the ffmpeg-devel mailing list