[FFmpeg-devel] [PATCH] make img_convert symbol conditional on lavc version, not libswscale

Reinhard Tartler siretart
Thu Jun 5 17:52:12 CEST 2008

Michael Niedermayer <michaelni at gmx.at> writes:

>> Is enabling img_convert really a problem?  Can't the scalers be used
>> side by side?
> Its duplicated code and bloat at least and as said i do not know if it works
> at all.

Duplicated code bloat is in general not an issue for general purpose
distributions. I acklowledge that it does matter on embedded devices.

Providing both scaler seems to work in at least mandriva and
Debian. I've noticed that if done like in mandriva, both libavcodec and
libswscale provide the following symbols with the same name:

 - sws_getCachedContext
 - sws_getContext
 - sws_freeContext
 - sws_scale.

For all corresponding function I've checked that they feature the same
signature, but provide a different implementation. I've therfore decided
to disable the implementation in libavcodecs img_resaple.c for

I think if these four functions where conditionally compiled (only
without libswscale) in libavcodec, it would be reasonable to apply that
patch to ffmpeg upstream as transition help for downstreams.

Reinhard Tartler, KeyID 945348A4

More information about the ffmpeg-devel mailing list