[FFmpeg-devel] [PATCH] make img_convert symbol conditional on lavc version, not libswscale

[Michael Niedermayer]

On Thu, Jun 05, 2008 at 09:52:13AM +0200, Diego Biurrun wrote:
> On Thu, Jun 05, 2008 at 12:38:11AM -0700, Baptiste Coudurier wrote:
> > 
> > Diego Biurrun wrote:
> > > On Tue, Jun 03, 2008 at 01:46:18PM +0200, Diego Biurrun wrote:
> > >> Currently we declare img_convert() in avcodec.h conditional to
> > >>
> > >> #if LIBAVCODEC_VERSION_INT < ((52<<16)+(0<<8)+0)
> > >>
> > >> However, in imgconvert.c, img_convert is defined conditional to
> > >>
> > >> #ifndef CONFIG_SWSCALE
> > >>
> > >> so that img_convert() is not available when compiling with swscale
> > >> enabled although it is declared in avcodec.h.
> > >>
> > >> Here is a patch to change the condition in imgconvert.c, which I believe
> > >> is the correct solution.
> > > 
> > > I will commit this tomorrow unless I hear objections.
> > 
> > imgresample.c uses img_convert, is it safe ?
> 
> That is indeed a problem, but separate from the one my patch addresses.
> The header promises the symbol conditional on lavc version, so the
> implementation must IMO follow.  We cannot make a condition based on
> CONFIG_SWSCALE in avcodec.h because installed headers do not #include
> config.h.

Iam not completely sure what is the correct awnser but
 --enable-swscale means "use the new API", one should not use that and then
 complain that the old isnt available anymore ...

thus IMHO the patch is wrong in the sense that either --enable-swscale should
not be used or the code using lavc should use swscale instead of the old API.

besides this the patch may or may not be totally buggy ive not checked this
but i think using the old scaler while the new is enabled has not been
considered when the code was written ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080605/f0cb1f67/attachment.pgp>