[FFmpeg-devel] [PATCH]silence some useless warnings in mkv demuxer

[Aurelien Jacobs]

On Sun, 1 Jun 2008 11:06:03 +0200
"Anton Khirnov" <wyskas at gmail.com> wrote:

> On Sat, May 31, 2008 at 6:52 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> > On Fri, 30 May 2008 17:39:17 +0200
> > "Anton Khirnov" <wyskas at gmail.com> wrote:
> >
> >> Hi,
> >> this patch makes these warnings go away:
> >>
> >> Unknown entry 0x73a4 in info header (segment UID) - is now read
> >> Unknown track header entry 0x55aa - ignoring (TrackFlagForced) - discard
> >> Unknown track header entry 0x23314f - ignoring (TrackTimecodeScale) -
> >> is used (is this ever different from 1?)
> >> Unknown track header entry 0xaa - ignoring (CodecDecodeAll) - discard
> >> Unknown attachedfile ID 0x46ae (File UID) - discard
> >> Ignoring unknown Edition entry ID 0x45db (EditionFlagDefault) - discard
> >
> > This patch should be split a little.
> >  - All the discarded ID could go in one patch.
> >  - The TrackTimecodeScale should be in a separate patch.
> >
> 
> Ok.

Both patches applied.
Thanks.

> >  - The segment UID is not used in your patch, and thus, there is no reason
> >   to read it. It should be discarded, as long as it's not used.
> >
> 
> Same could be said for writing/muxing_app for example.

Indeed, this could be removed too. Patch welcome.

> But I don't
> insist on it being there right now, so don't apply it if you don't
> want to.

Well, if you plan on using this in a future patch, then send this along
with your future patch. It will be welcome.
For now, I won't apply it.

Aurel