[FFmpeg-devel] [PATCH] AAC Decoder round 4

Michael Niedermayer michaelni
Wed Jul 30 17:17:52 CEST 2008


On Wed, Jul 30, 2008 at 05:06:52PM +0300, Kostya wrote:
> On Wed, Jul 30, 2008 at 03:02:49PM +0200, Michael Niedermayer wrote:
> > On Wed, Jul 30, 2008 at 01:54:16PM +0100, Robert Swain wrote:
> [...]
> > > Kostya has said that he would like these changes reverted as he uses
> > > these elements of these data structures in his code.
> > 
> > He can just put these 2 fields in the 2 structs back with his encoder patch.
> > But as long as they are not used i will not approve unused variables, its
> > far too hard to keep track of what might be used one day and then check back
> > if that actually happened or if we ended up with some permamently unused
> > fields in structs.
>  
> fine with me
> I'd like to submit my encoder for review ASAP and it's hard to do without
> stable (i.e. fully committed) AAC decoder in SVN.

The AAC decoder is big, it will take time to reach svn even if i and robert
try hard to move quickly ...
But ill try to review AAC patches before others when there is one posted.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080730/98b5707d/attachment.pgp>



More information about the ffmpeg-devel mailing list