[FFmpeg-devel] [PATCH] h264 luma interpolation 8x8 for altivec

[Guillaume POIRIER]

Hello,

2008/7/23 Guillaume Poirier <gpoirier at mplayerhq.hu>:
> On Jul 22, 2008, at 11:26 , Guillaume POIRIER wrote:
> Ok, I finally had time to sit down and test the latest known incarnation of
> the third part of Mauricio's patch.
> Compared to yesterday's patch, I had to fix fix the code so that it uses
> newer syntax of LD32()'s macro.
>
> Since the patch didn't allow lavc to decode my samples correctly, I went
> back to Mauricio's latest known 3rd patch of his patchset, to find out that
> I had made a mistake in an intermediate version of these ported patches.
>
> Attached is Mauricio's patch ported to current SVN (so it features the
> "SIZE" => "16" change, which I believe doesn't change anything regarding the
> correctness of the output).
>
> Here's what lavc has to say when I try to decode a sample with it:
> [h264 @ 0x6f8970]number of reference frames exceeds max (probably corrupt
> input), discarding one
> [h264 @ 0x6f8970]number of reference frames exceeds max (probably corrupt
> input), discarding one
> [....]
>
> Mauricio, could you have a look of what's wrong with your patch? If you
> don't, this patch may rot on my computer for a while....
>
> Guillaume

It appears that this problem wasn't due to Mauricio's patch, but was
due to a change in h264.c.

I did an md5sum diff between the video output of patched and unpatched
output, and it's not identical, as in the diff shows:

diff -u md5sums*
--- md5sums	2008-07-25 13:52:19.000000000 +0200
+++ md5sums.new	2008-07-25 13:45:28.000000000 +0200
@@ -145,15 +145,15 @@
 e0efe308955bb1b4ff9cfbb74968db3e frame00000144
 a93ccb4da8cba3b9dadd806c40933ed5 frame00000145
 fae0d64f7798b9bfa59946c8084c327e frame00000146
-57b411b97e9e87d36a71a238a233c207 frame00000147
+02eb6c61f922a50ed880c9b0a43fdd80 frame00000147
 4bead55cbe7b078049df25ac4b489626 frame00000148
 c1e35cbafaa2911053f84d87f74650c4 frame00000149
 d75a9b01c5ea100219d98569f27c2bf2 frame00000150
 c7df21114aaa16907ad2991488f61d54 frame00000151
 05b171c71151c1b587445ec636367e26 frame00000152
 f02f1ddce391025e71c51067fb34e1bd frame00000153
-9863c4ebbd8a32fe155f7440b4d27c07 frame00000154
-3ca120bce7e48289f958afe229f0252d frame00000155
+5412191453eb6872fc4ca29a8a0cd811 frame00000154
+5dcb0ef2a6f81f1c305d44a84eeaff57 frame00000155
 8ab9338bb576dcfd70f200987321fa95 frame00000156
 20d90b1ca86db1e6403a3b08a14dd2eb frame00000157
 26e85517a41c0248c45c093f2b19410f frame00000158
@@ -424,7 +424,7 @@
 7d30672495b4b3b13cffecaee26d8f33 frame00000423
 269bedccee08037e655435024b6fffc3 frame00000424
 4defb5ab01944c174a529990367cd354 frame00000425
-c0737991a94098d65a998f22258978c3 frame00000426
+fbb8a211711800f4d1d2e231913b139c frame00000426
 27989b3b117144c59c020afef4737424 frame00000427
 3113f3bcc9b38e5678b2774b8f6a8374 frame00000428
 0faec4ba6d2538f3e72ca7d31975d7e0 frame00000429


Mauricio, are you reading this mailing list at all these days?

Guillaume
-- 
Charles Dickens  - "He would make a lovely corpse."