[FFmpeg-devel] [PATCH] movenc.c fix (Was: Can av_write_frame() modify pkt.data?)

[Baptiste Coudurier]

Hi,

Aurelien Jacobs wrote:
> Luca Abeni wrote:
> 
>> Luca Abeni wrote: [...]
>>> I'll test h.264 (encoded through libavcodec + x264 with default
>>> options) in mp4, mov, matroska, and flv. Is this enough, or
>>> should I add some more tests?
>> Ok, here are the two possible patches (BTW, I just realized that
>> the first one looked smaller because it only fixed the mov muxer,
>> and did not fix the flv and mkv muxers...).
> 
> The patch passing a ByteIOContext to ff_avc_parse_nal_units() is
> better IMO. It avoid one malloc/copy step for every packet.
> 

True, but IMHO it is one step away from moving this code into a
bitstream filter.

Also this code could not be used also as standalone. Yes, I know this is
not intended since not part of public API, but there are some very
useful, at least to me, functions into FFmpeg codebase
(ff_find_start_code being one, this one will too).

Also patch using ByteIOContext more complex IMHO.

Any other opinion ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA