[FFmpeg-devel] [PATCH] movenc.c fix (Was: Can av_write_frame() modify pkt.data?)

[Michael Niedermayer]

On Thu, Jul 24, 2008 at 10:15:34AM +0200, Luca Abeni wrote:
> Hi Mike,
> 
> Mike Melanson wrote:
> [...]
> >> I'll test h.264 (encoded through libavcodec + x264 with default options) in mp4,
> >> mov, matroska, and flv. Is this enough, or should I add some more tests?
> > 
> > I'll test Apple QuickTime (on both Mac and Windows). Just give me the 
> > right command lines.
> 
> See my previous email for the command lines. Anyway, I verified that the files
> generated after applying the patches are identical to the files generated
> without the patches, so I do not think that additional tests are needed.
> 
> > Then, if we can guarantee that the output will be 
> > bit exact on all platforms, we can add the tests to FATE to ensure that 
> > the functionality does not break.
> 
> I did not check if "make test" already tests these codec/muxer combinations
> (h.264 in mp4, mov, mkv, and flv), but I think that it should... So, someone
> should make sure that the "standard" regression tests already cover this case,

No h.264 encoder in ffmpeg no encoder/muxer tests with h264 in make test ...
... unless we put a h264 video in svn :)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080724/18337598/attachment.pgp>