[FFmpeg-devel] [PATCH] movenc.c fix (Was: Can av_write_frame() modify pkt.data?)

Mike Melanson mike
Thu Jul 24 09:04:25 CEST 2008


Luca Abeni wrote:
> Hi Baptiste,
> 
> Baptiste Coudurier wrote:
> [...]
>>> Just a question: which kind of tests should I run to be sure that my patches
>>> do not break anything? Is "make test" enough, or there is some additional
>>> test that I should run to test this code?
>>>
>> Well, ensure that created file is playable by every player including
>> quicktime I'd say.
> 
> I have no closed-source software on my computer ;-)
> So, I'll be only able to test ffplay, vlc, and mplayer...
> 
> I'll test h.264 (encoded through libavcodec + x264 with default options) in mp4,
> mov, matroska, and flv. Is this enough, or should I add some more tests?

I'll test Apple QuickTime (on both Mac and Windows). Just give me the 
right command lines. Then, if we can guarantee that the output will be 
bit exact on all platforms, we can add the tests to FATE to ensure that 
the functionality does not break.

Just let me know the commands to test.

-- 
	-Mike Melanson




More information about the ffmpeg-devel mailing list