[FFmpeg-devel] [PATCH] Warn about PAFF & Spatial

[Carl Eugen Hoyos]

Hi!

Loren Merritt <lorenm <at> u.washington.edu> writes:

> > The warning for interlaced + spatial direct was (accidentally I think)
> > removed in r11806 when MBAFF + spatial direct was implemented.
> > So I am for restoring it as per the patch.
> 
> Not accidental. I removed the warning because I was unaware of any 
> difference between PAFF direct and MBAFF direct, and I still don't see 
> anywhere in the standard that they differ.

(Not surprisingly) You were probably right:
While I know of one file in the conformance suite, HCAFF1_HHI, that claims not
to decode correctly because of PAFF and spatial direct, but has all crc's
correct (and a second one, Sharp_MP_PAFF_1r2, that decodes much better than the
message would suggest), cabac_mot_picaff0_full shows the typical artifacts that
are reported so often, but does not contain spatial direct mode.

Should I remove the warning?

Carl Eugen