[FFmpeg-devel] [PATCH] Fix roq encoding

[Michael Niedermayer]

On Sat, Jul 19, 2008 at 04:25:17AM +0200, Vitor Sessak wrote:
> Michael Niedermayer wrote:
>> On Sat, Jul 19, 2008 at 12:23:28AM +0200, Vitor Sessak wrote:
>>> Hi,
>>>
>>> The following patch fix the issue 548. Not that I fully understand why
>>> before it was ok not to set avctx->coded_frame and now it crashes...
>>>
>>> -Vitor
>>>
>>> PS: nice to know there is someone who used this encoder...
>>> Index: libavcodec/roqvideoenc.c
>>> ===================================================================
>>> --- libavcodec/roqvideoenc.c	(revision 14271)
>>> +++ libavcodec/roqvideoenc.c	(working copy)
>>> @@ -1037,6 +1037,8 @@
>>>      /* Encode the actual frame */
>>>      roq_encode_video(enc);
>>>  +    avctx->coded_frame = enc->last_frame;
>> I think it should be set to current_frame before the pointers
>> are swapped, that would be cleaner
>
> I agree, like the attached patch?

yes, patch ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080719/1328382b/attachment.pgp>