[FFmpeg-devel] [PATCH] flac encoding, issue 526

[Michael Niedermayer]

On Thu, Jul 17, 2008 at 04:41:39PM -0400, Justin Ruggles wrote:
> Hi,
> 
> Michael Niedermayer wrote:
> > On Thu, Jul 17, 2008 at 09:51:53PM +0200, Mathieu Velten wrote:
> >> of course I forgot the patch...
> > 
> > I think this patch breaks flac encoding in all cases except when the output is
> > a raw flac file.
> 
> Michael beat me to it. :)
> 
> The general idea will work, but the streaminfo header needs to be in the
> codec extradata for muxers other than raw flac to work properly.
> 
> I can think of a couple options. I don't know which, if any, is more
> correct though.  And sometimes I tend to overlook simple solutions... so
> maybe someone else will have other suggestions.
> 
> 1) The FLAC encoder can know when it has encoded the last frame because
> of CODEC_CAP_SMALL_LAST_FRAME.  It will either be shorter than all the
> previous frames or the input samples array will be NULL.  The encoder
> could update the extradata at that point in case any muxer wants to go
> back and reuse the new data to update the header.  I'm not sure if this
> is ok to do though.

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080717/bf141f0f/attachment.pgp>