[FFmpeg-devel] libraries linked with libX11 on GNU/kFreeBSD

[Måns Rullgård]

Reinhard Tartler wrote:
>
> ffmpeg-free

Sorry, don't know what that is.  The name suggests it might be something
without ffmpeg, so why are you asking about it here?

> links with -Wl,--as-needed on GNU/Linux, so the resulting
> libraries are not linked with libX11. This is something required by VLC.

I'm confused.  Does VLC require libX11, or does is forbid it?  I find
both kind of hard to believe.

> On GNU/kFreeBSD, -Wl,--as-needed is not used, so VLC fails to build.
> Please find below a patch to fix that.
>
> --- ffmpeg-free-0.svn20080206.orig/configure
> +++ ffmpeg-free-0.svn20080206/configure

OMG, that's old.

> @@ -1289,6 +1289,9 @@
>          SLIB_UNINSTALL_EXTRA_CMD='rm -f
>          "$(LIBDIR)"/$(LIBPREF)$(NAME)_dll.a
>          "$(LIBDIR)"/$(LIBPREF)$(NAME)_dll.lib'
>          vhook="no"
>          ;;
> +    gnu/kfreebsd)
> +        LDLATEFLAGS="-Wl,--as-needed $LDLATEFLAGS"
> +        ;;
>
>      *)
>          targetos="${targetos}-UNKNOWN"

The use of this flag should depend on the linker, not the OS.  If
existing code sets this based on OS, that code is wrong and should
be fixed.  Patches adding incorrect code are rejected, regardless
of what already exists.

> This patch originates from Aurelien Jarno <aurel32 at debian.org> and has

Oh, Debian.  I might have guessed.  The Debian FFmpeg package is indeed
about as free of FFmpeg as you can get.

> been applied to the debian package. Please consider applying it to svn
> as well.

I take something being applied to a debian package as a warning sign.

-- 
M?ns Rullg?rd
mans at mansr.com