[FFmpeg-devel] [PATCH] Use LIBAVCODEC_BUILD rather than the deprecated avcodec_build() in cmdutils.c:show_version()

[Michael Niedermayer]

On Sun, Jul 13, 2008 at 11:21:35PM +0200, Stefano Sabatini wrote:
> On date Sunday 2008-07-13 22:57:15 +0200, Michael Niedermayer encoded:
> > On Sun, Jul 13, 2008 at 07:08:44PM +0200, Stefano Sabatini wrote:
> > > avcodec_build() has been deprecated, LIBAV*_BUILD also look pointless
> > > so it seems better to directly use LIBAV*_VERSION_INT instead.
> > > 
> > > Regards.
> > > -- 
> > > FFmpeg = Faboulous and Fostering Multimedia Pitiless Explosive God
> > 
> > > Index: cmdutils.c
> > > ===================================================================
> > > --- cmdutils.c	(revision 14208)
> > > +++ cmdutils.c	(working copy)
> > > @@ -223,7 +223,7 @@
> > >             "libavcodec  %d\n"
> > >             "libavformat %d\n"
> > >             "libavdevice %d\n",
> > > -           LIBAVUTIL_BUILD, avcodec_build(), LIBAVFORMAT_BUILD, LIBAVDEVICE_BUILD);
> > > +           LIBAVUTIL_VERSION_INT, LIBAVCODEC_VERSION_INT, LIBAVFORMAT_VERSION_INT, LIBAVDEVICE_VERSION_INT);
> > 
> > not ok
> > avcodec_build() is not the same as LIBAVCODEC_VERSION_INT
> 
> That's right, new patch attached.
[...]
> -           LIBAVUTIL_BUILD, avcodec_build(), LIBAVFORMAT_BUILD, LIBAVDEVICE_BUILD);
> +           LIBAVUTIL_BUILD, LIBAVCODEC_BUILD, LIBAVFORMAT_BUILD, LIBAVDEVICE_BUILD);

avcodec_build() is also not the same as LIBAVCODEC_BUILD

Let me give you a hint
avcodec_build() returns the "build" of the linked library
LIBAVCODEC_BUILD returns the "build" of the included header

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080713/00e6cf36/attachment.pgp>