[FFmpeg-devel] [PATCH] n-th try to get the MPEG-PS demuxer functional

[Michael Niedermayer]

On Sat, Jul 12, 2008 at 09:50:24PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
[...]
> > Thus summary, MPEG-PS does not contain any mandatory element to
> > identify the used codec.
> 
> Yes, this is correct.  I never said otherwise.
> 
> You are probably confusing this with damaged MPEG-TS streams without
> PAT or PMT.  Those elements *are* required.

Could easily be, i never can remember what is what in mpeg-ps/ts a while
after not looking at the specs.


[...]
> > Index: libavformat/mpeg.c
> > ===================================================================
> > --- libavformat/mpeg.c	(revision 14080)
> > +++ libavformat/mpeg.c	(working copy)
> > @@ -459,7 +459,7 @@
> >          if(!memcmp(buf, avs_seqh, 4) && (buf[6] != 0 || buf[7] != 1))
> >              codec_id = CODEC_ID_CAVS;
> >          else
> > -            codec_id = CODEC_ID_MPEG2VIDEO;
> > +            codec_id = CODEC_ID_PROBE;
> >          type = CODEC_TYPE_VIDEO;
> >      } else if (startcode >= 0x1c0 && startcode <= 0x1df) {
> >          type = CODEC_TYPE_AUDIO;
> 
> Patch OK.  

Great, applied!


> That said, wouldn't it be better to support CAVS through
> the probe functionality too?

Yes, it would need a cavs_probe() or cavs raw demuxer with such a
function though. Iam not volunteering to write either, maybe Stefan
would volunteer though if someone would ask him ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080713/d1f68a31/attachment.pgp>