[FFmpeg-devel] [PATCH] RealAudio SIPR @16k decoder (3/4) acelp_vectors

[Aurelien Jacobs]

On Sat, 12 Jul 2008 16:03:48 +0700
"Vladimir Voroshilov" <voroshil at gmail.com> wrote:

> 2008/7/12 Diego Biurrun <diego at biurrun.de>:
> > On Sat, Jul 12, 2008 at 02:16:48PM +0700, Vladimir Voroshilov wrote:
> >>
> >> Here is first draft version of fixed-point RealAudio sipr decoder
> >> (only 16kHz mode)
> >>
> >> This patch contains required changes in acelp_vectors
> >
> > Sure? :)
> 
> Hm. I was sure :)
> 
> [...]
> 
> --- a/libavcodec/acelp_vectors.c
> +++ b/libavcodec/acelp_vectors.c
> @@ -126,6 +126,28 @@ void ff_acelp_fc_pulse_per_track(
>      fc_v[tab2[pulse_indexes]] += (pulse_signs & 1) ? 8191 : -8192;
>  }
>  
> +void ff_acelp_two_pulses_per_track(

It seems this function is only used in sipr.c. So I don't understand
why you are putting it in a common file used by other codecs ?
Unless you plan to use this function in other codecs, it would
probably better fit in sipr.c.

Aurel