[FFmpeg-devel] C99 or GCC extensions

[Axel Holzinger]

Axel Holzinger <aholzinger at gmx.de> writes:

> "M?ns Rullg?rd" <mans at mansr.com> writes:
> > It is customary to write "static type" rather than "type
> static".
> 
> Will do so.
> 
> > Lose the backslashes.
> 
> Ditto.
> 
> > >  #elif defined(CONFIG_FASTDIV)
> > >  #    define FASTDIV(a,b)
> > ((uint32_t)((((uint64_t)a)*ff_inverse[b])>>32))
> > >  #else
> >
> > Unrelated to this change, machine-specific code should go into
> > subdirs, IMHO.

Okay, didn't get that. Yes it would be better to put the machine-
specific part into subdirs. But in libavutil there aren't yet any
subdirs, so we would start doing so. I will study how this is
done in lavf or lavc, but don't be too impatient, I'm still
learning :-)

So here's version two with the promised changes.

All the best
Axel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fastdiv_internal_h_v2.diff
Type: application/octet-stream
Size: 1313 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080711/6c2344ba/attachment.obj>