[FFmpeg-devel] [PATCH] Make rtpenc.c SSRC randomly set

[Luca Abeni]

Hi Stefano,

Stefano Sabatini wrote:
> Hi all,
> 
> RFC 3550 (RTP) states:
> | SSRC: 32 bits
> |      The SSRC field identifies the synchronization source.  This
> |      identifier SHOULD be chosen randomly, with the intent that no two
> |      synchronization sources within the same RTP session will have the
> |      same SSRC identifier.
> 
> Currently rtpenc.c uses always a value of 0.

Note that random() used to be used here, but has been removed:
http://svn.mplayerhq.hu/ffmpeg/trunk/libavformat/rtpenc.c?r1=5090&r2=5249

I am not sure what the correct solution would be (and I have to admit that
I am not a fan of the "random() vs no random()" discussions... I just tend
to trust other people about this kind of issues), but if someone finds a
solution on which everyone agree I'll be happy to ack it.
(In any case, AFAIK this is not causing any real issue... So, even if we
are not fully compliant with the RFC there are no practical problems.)


				Luca