[FFmpeg-devel] [PATCH] 3 trivial fixes to enforce order of operations

[Diego Biurrun]

On Fri, Jul 04, 2008 at 02:03:16AM +0200, Michael Niedermayer wrote:
> On Wed, Jul 02, 2008 at 01:55:42PM -0400, Shane wrote:
> > 
> > Three trivial patches to enforce the intended order of operations.
> > 
> >           !flags & y     vs.    !(flags & y)
> > 
> > --- libavformat/movenc.c	(revision 17253)
> > +++ libavformat/movenc.c	(working copy)
> > @@ -1235,7 +1235,7 @@
> >      if (s->title[0]   || s->author[0] || s->album[0] || s->year ||
> >          s->comment[0] || s->genre[0]  || s->track ||
> >         (mov->mode == MODE_MOV &&
> > -      ((mov->tracks[0].enc && !mov->tracks[0].enc->flags & CODEC_FLAG_BITEXACT) || req))) {
> > +      ((mov->tracks[0].enc && !(mov->tracks[0].enc->flags & CODEC_FLAG_BITEXACT)) || req))) {
> >          offset_t pos = url_ftell(pb);
> >  
> >          put_be32(pb, 0); /* size */
> 
> looks ok

The code appears to be gone from HEAD.

Diego