[FFmpeg-devel] [PATCH] AAC Decoder round 3

[Diego Biurrun]

On Tue, Jul 01, 2008 at 05:18:01PM +0100, Robert Swain wrote:
> 2008/7/1 Diego Biurrun <diego at biurrun.de>:
> > On Tue, Jul 01, 2008 at 04:10:38PM +0100, Robert Swain wrote:
> >> 2008/7/1 Robert Swain <robert.swain at gmail.com>:
> >> > 2008/7/1 Diego Biurrun <diego at biurrun.de>:
> >> >> What I also miss is a comment at the top of the file that explains which
> >> >> parts of AAC are supported and which are not.  I must have asked you
> >> >> about a dozen times and I keep forgetting, so it's a good idea to put
> >> >> this into writing :)
> >> >
> >> > I don't recall you saying this to me but maybe I'm wrong. I was
> >> > actually thinking about looking through the code and figuring this out
> >> > so we know what isn't supported and so on. I'll look into this but I'd
> >> > appreciate it not being a blocker for getting this into svn. I will
> >> > add it but it will take some time to check.
> >>
> >> See attached. The tools list should be exhaustive. The Audio Object
> >> Types comments are only for those in the enum but AOTs are just unions
> >> of tools. How do you want it formatting?
> >
> > Wow, I wasn't expecting that much detail.  I was mainly wondering about
> > SBR, HE-AAC and all those buzzwords surrounding AAC that libfaad
> > supports.
> 
> I doubt we'll ever implement most of those that are not supported as
> they're probably never used and are maybe even useless. :) Maybe I
> should add notes for HE AAC v1 and v2 as they are probably of most
> interest of the unsupported stuff.

Yes, something like that.  Maybe add notes about things that libfaad
supports and we don't.

Diego