[FFmpeg-devel] [RFC] write standard stsd tags and objecttype for mp4/3gp

[Baptiste Coudurier]

Michael Niedermayer wrote:
> On Mon, Jan 28, 2008 at 12:44:57PM +0100, Baptiste Coudurier wrote:
>> Hi
>>
>> I had that in my tree since some time now anyway, and it will avoid
>> other people wasting their time.
>>
>> This patch should do what's needed, except a few things:
>>
>> - stream copying mpeg-2 removes sequence header and puts it in extradata
>> -> is the mpegvideo split function actually used ? Can mpeg2 be stored
>> in any container without seq header ?
>> -> -vglobal 4 makes it working but it still puts extradata, and then
>> extradata is written in decodec specific tag, Im pretty sure this is
>> should not be done.
>>
>> - set correct profiles for mpeg-2.
>>
>> One patch to move prefered object types to be be chosen first.
>> One other patch to enable muxing.
> 
> also note, that as soon as you export the AVCodecTag tables from the muxer
> the following code in ffmpeg.c should provide some slight protection against
> the use of unsupported codec_tags with stream copy
> 
> if(!codec->codec_tag){
>     if(   !os->oformat->codec_tag
>         || av_codec_get_id (os->oformat->codec_tag, icodec->codec_tag) > 0
>         || av_codec_get_tag(os->oformat->codec_tag, icodec->codec_id) <= 0)
>         codec->codec_tag = icodec->codec_tag;
> }
> 

Great, done.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312