[FFmpeg-devel] [RFC] write standard stsd tags and objecttype for mp4/3gp

[Michael Niedermayer]

Hi

On Mon, Jan 28, 2008 at 02:46:15PM +0100, Baptiste Coudurier wrote:
[...]
> > [...]
> >> +    track->tag = tag;
> >>      return tag;
> > 
> > i think retunng the tag and vissibly setting it is more readable
> > that is IMHO
> >  track->tag = mov_find_video_codec_tag(s, track);
> > is better than
> > if (!mov_find_codec_tag(s, track)) {
> >     av_log(s, AV_LOG_ERROR, "track %d: could not find tag for codec\n", i);
> >     return -1;
> > }
> > 
> > where mov_find_codec_tag() has a "hidden" sideeffect of setting track->tag
> > 
> 
> Im fine with it.
> 
> Updated patch attached.

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080128/61eff999/attachment.pgp>