[FFmpeg-devel] [PATCH] add DECLARE_ASM_CONST

Reimar Döffinger Reimar.Doeffinger
Mon Jan 28 12:01:53 CET 2008


Hello,
On Mon, Jan 28, 2008 at 03:35:28PM +1100, mark cox wrote:
> wouldn't
> 
> +  #define DECLARE_ASM_CONST(n,t)     static const t attribute_used
> __attribute__ ((aligned (n)))
> 
> be neater, and closer to the original syntax.
> 
> +DECLARE_ASM_CONST(8, uint64_t, bone)= 0x0101010101010101LL;
> 
> would become
> 
> +DECLARE_ASM_CONST(8, uint64_t) bone = 0x0101010101010101LL;
> 
> or, am i missing something?

Well, current syntax is in line with DECLARE_ALIGNED, that's all there
is too it, and seemed like enough of a reason to do it like this.
I am also not sure, maybe there are compilers that need the attribute
stuff behind the variable name?




More information about the ffmpeg-devel mailing list