[FFmpeg-devel] [RFC] replace some static with asm_visibility or so

[Baptiste Coudurier]

Hi,

Michael Niedermayer wrote:
> On Mon, Jan 28, 2008 at 01:36:57AM +0100, Baptiste Coudurier wrote:
>> Michael Niedermayer wrote:
>>> On Mon, Jan 28, 2008 at 12:36:40AM +0100, Baptiste Coudurier wrote:
>>>> Michael Niedermayer wrote:
>>>>> On Mon, Jan 28, 2008 at 12:17:15AM +0100, Baptiste Coudurier wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Uoti Urpala wrote:
>>>>>>> [...]
>>>>>>>
>>>>>>> Since I've already tested that and shown it to work I see little reason
>>>>>>> to do that for all files when it seems unlikely to get included in
>>>>>>> FFmpeg anyway and I have no interest in maintaining a fork.
>>>>>>>
>>>>>> FYI, I might be reconsidering my interest in it.
>>>>> if theres anything i can do to help you, just say it!
>>>>> i really would like to finally fix the mov demuxer so it conforms to
>>>>> the API in respect to codec_tag
>>>>>
>>>> All you will do is breaking stream copy.
>>> that doesnt work currently anyway, object ids are lost ...
>> It works for aac and mpeg4.
>>
>>> and dont fear i plan to change the muxer as well,
>> Well, feel free to submit a patch which change the muxer to mux mp4 with
>> correct object type id (don't forget mpeg-2, and aac profiles),
>> and with working mp4->mov remux too.
>>
>> Im sure there won't be any problem exporting object type id then.
> 
> ok first patch, this ensures that the correct stsd tag is writtin for
> .mp4
> 
> [...]
> 
> 
> 
> ------------------------------------------------------------------------
> 
> Index: movenc.c
> ===================================================================
> --- movenc.c	(revision 11623)
> +++ movenc.c	(working copy)
> @@ -474,6 +474,15 @@
>      return 0;
>  }
>  
> +static int mp4_find_video_spec_tag(AVFormatContext *s, MOVTrack *track)
> +{
> +    switch(track->enc->codec_id){
> +    case CODEC_ID_H263: return MKTAG('s', '2', '6', '3');
> +    case CODEC_ID_H264: return MKTAG('a', 'v', 'c', '1');
> +    default           : return MKTAG('m', 'p', '4', 'v');
> +    }

s263 is not valid in mp4 AFAIK.

> [...]
>
>  }
>  
> +static int mp4_find_audio_spec_tag(AVFormatContext *s, MOVTrack *track)
> +{
> +    switch(track->enc->codec_id){
> +    case CODEC_ID_AMR_NB: return MKTAG('s', 'a', 'm', 'r');
> +    case CODEC_ID_AMR_WB: return MKTAG('s', 'a', 'w', 'b');
> +    default             : return MKTAG('m', 'p', '4', 'a');
> +    }

samr/sawb either.

Could you please start a new thread for patch submission, it makes
reviewing easier ;)

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312