[FFmpeg-devel] [RFC] replace some static with asm_visibility or so

Michael Niedermayer michaelni
Sun Jan 27 16:20:14 CET 2008


On Sun, Jan 27, 2008 at 04:59:28PM +0200, Uoti Urpala wrote:
> On Sun, 2008-01-27 at 15:53 +0100, Reimar D?ffinger wrote:
> > Hello,8 at 03:10:39PM +0100, Reimar D?ffinger wrote:
> > > as you may know current code does not compile with ICC and assembler due
> > > to it optimizing away all the constants.
> 
> > On second though, something like
> > #define DECLARE_ASM_CONST(n,t,v) static const t v attribute_used __attribute__ ((aligned (n)))
> > might work out nicer (less clutter).
> > Also makes sure nobody uses something global, non-const from asm code without
> > thinking.
> > Opinions, alternatives?
> 
> The "right" way to fix it would of course be to use proper asm
> arguments.

you are quite predictable
i was already wondering how long it takes until you suggest we break half
of the asms

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker, user
questions for the command line tools ffmpeg, ffplay, ... as well as questions
about how to use libav* should be sent to the ffmpeg-user mailinglist.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080127/891f2988/attachment.pgp>



More information about the ffmpeg-devel mailing list