[FFmpeg-devel] regression - mpeg2 interlace/topfield flags not set anymore

[Reimar Döffinger]

Hello,
On Sun, Jan 27, 2008 at 01:18:54PM +0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
> > Sorry, this is a patch that actually compiles. No idea if it works
> > though, I am not running a broken os right now :-P
> >
> > Index: libavcodec/eval.c
> > ===================================================================
> > --- libavcodec/eval.c	(revision 11627)
> > +++ libavcodec/eval.c	(working copy)
> > @@ -91,6 +91,8 @@
> >      double d;
> >      char *next;
> >      d = strtod(name, &next);
> > +    if (d == 0 && name[0] == '0' && name[1] == 'x') // HACK around broken strtod
> > +        d = strtol(name, &next, 0);
> >      /* if parsing succeeded, check for and interpret postfixes */
> >      if (next!=name) {
> 
> This will break non-integer hex values.

I think this should not break anything, since it should only do
something in already broken cases.
But it is true that it will not handle hex floating point values
(including integer ones like 0x1p4), though to my knowledge these are
not used internally at least.
Either way it was only meant as a quick hack against the worst problems,
I certainly would not endorse it as a permanent solution.

Greetings,
Reimar D?ffinger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080127/697c5bac/attachment.pgp>