[FFmpeg-devel] [PATCH] Fix for lowres decoding support on ARM

[Michael Niedermayer]

On Sun, Jan 27, 2008 at 01:03:13AM +0200, Siarhei Siamashka wrote:
> Hello,
> 
> Video decoding with 'lowres' option enabled is currently broken for ARM.
> A patch to fix this problem is attached.
> 
> Apparently lowres decoding is also broken when using 'alpha', 'bfin', 
> 'mlib', 'ps2', 'sh4' and 'sparc' optimizations (every platform except 
> for 'i386' and 'ppc').
> 
> Also the existence of this problem shows that lowres decoding is not 
> properly covered by regression tests.

> Index: libavcodec/armv4l/dsputil_arm.c
> ===================================================================
> --- libavcodec/armv4l/dsputil_arm.c	(revision 11625)
> +++ libavcodec/armv4l/dsputil_arm.c	(working copy)
> @@ -209,49 +209,51 @@
>      ff_put_pixels_clamped = c->put_pixels_clamped;
>      ff_add_pixels_clamped = c->add_pixels_clamped;
>  
> -    if(idct_algo == FF_IDCT_AUTO){
> +    if (avctx->lowres == 0) {
> +        if(idct_algo == FF_IDCT_AUTO){
>  #if defined(HAVE_IPP)
> -        idct_algo = FF_IDCT_IPP;
> +            idct_algo = FF_IDCT_IPP;
>  #elif defined(HAVE_ARMV6)
> -        idct_algo = FF_IDCT_SIMPLEARMV6;
> +            idct_algo = FF_IDCT_SIMPLEARMV6;
>  #elif defined(HAVE_ARMV5TE)
> -        idct_algo = FF_IDCT_SIMPLEARMV5TE;
> +            idct_algo = FF_IDCT_SIMPLEARMV5TE;

mixes functional and cosmetic changes -> split it in 2 patches please
[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080127/68382e40/attachment.pgp>