[FFmpeg-devel] [PATCH] to support newer neAAC for libfaadbin

[Måns Rullgård]

"Zdenek Kabelac" <zdenek.kabelac at gmail.com> writes:

> 2008/1/25, M?ns Rullg?rd <mans at mansr.com>:
>> "Zdenek Kabelac" <zdenek.kabelac at gmail.com> writes:
>>
>> > Really around 100 bytes - just check the compilation size - It also
>> > might safe relocation on the startup I think.
>>
>> Removing the 'static' saves another kilobyte.
>
> hmm good catch :) thought I'm not in which code sections this ends if
> its library - I'll have to look for the difference ;)

The string constants should end up in the read-only data section.

>> > Yep - but I don't see it as total mess - IMHO its quite reasonable
>> > and efficient - but if you see a solution which would be cleaner and
>> > would have the same functionality and would be without compiler
>> > warnings - I'd love to see it (I did not created dlsym API and C
>> > casting rules...)
>>
>> OK, svn up and see for yourself.
>
> Yeah nice - personally I'm using stronger type rules even for
> compiling C code - but if this less strict code is fine for you and

There is nothing less strict about it.  dlsym() returns a void *.
Explicitly casting it to the type you hope it has makes no difference
at all.

> there would be no objections to adapt few other 'lib' sources to use
> this style of library access using that would be nice and would make
> package installation much simpler.

Ideally, we should have no external dependencies, and we're getting
closer to that goal by the day.

> (Personally I don't like to install 20+ libraries when I'm sure I'll
> need just one).

Current FFmpeg can be linked against exactly 10 external codec libs.

-- 
M?ns Rullg?rd
mans at mansr.com