[FFmpeg-devel] [PATCH] to support newer neAAC for libfaadbin

[Måns Rullgård]

"Zdenek Kabelac" <zdenek.kabelac at gmail.com> writes:

> 2008/1/25, M?ns Rullg?rd <mans at mansr.com>:
>> "Zdenek Kabelac" <zdenek.kabelac at gmail.com> writes:
>>
>> > 2008/1/24, M?ns Rullg?rd <mans at mansr.com>:
>> >> "Zdenek Kabelac" <zdenek.kabelac at gmail.com> writes:
>> >>
>> >> > 2008/1/24, M?ns Rullg?rd <mans at mansr.com>:
>> >> >>
>> >> >> Zdenek Kabelac wrote:
>> >> >> > Hi
>> >> >> >
>> > This remined me one minor thing - this small patch safes couple of
>> > bytes in our multigigabyte world these days ;)
>>
>> > -    do { static const char* n = AV_STRINGIFY(faacDec ## a);             \
>> > +    do { static const char n[] = AV_STRINGIFY(faacDec ## a);            \
>>
>> I'd be surprised if this resulted in any difference at all in the
>> compiled code.  Rather than micro-optimising things like that, feel
>
> Really around 100 bytes - just check the compilation size - It also
> might safe relocation on the startup I think.

Removing the 'static' saves another kilobyte.

>> free to clean it up a bit instead.  It's a total mess as is.  Oh wait,
>> it was you who wrote it to begin with...
>
> Yep - but I don't see it as total mess - IMHO its quite reasonable
> and efficient - but if you see a solution which would be cleaner and
> would have the same functionality and would be without compiler
> warnings - I'd love to see it (I did not created dlsym API and C
> casting rules...)

OK, svn up and see for yourself.

-- 
M?ns Rullg?rd
mans at mansr.com