[FFmpeg-devel] [PATCH] to support newer neAAC for libfaadbin

[Zdenek Kabelac]

2008/1/24, M?ns Rullg?rd <mans at mansr.com>:
> "Zdenek Kabelac" <zdenek.kabelac at gmail.com> writes:
>
> > 2008/1/24, M?ns Rullg?rd <mans at mansr.com>:
> >>
> >> Zdenek Kabelac wrote:
> >> > Hi
> >> >
> >> > Here is a small patch to adapt libfaad.c binary version to link
> >> > properly with newer header file (it was generating wrong symbol names)
> >> >
> >> > Patch also unifies error messages with just one prefix FAAD library
> >> > and aligns one wrongly indented line in the source file.
>
> > 2. Unified logging prefix
>
> I'm not sure I agree with this.  I'm all for consistency, but
> prefixing messages like this is redundant as the context pointer
> passed to av_log() already identifies the caller.

Well its up to you - it just should look a bit more consistent...

This remined me one minor thing - this small patch safes couple of
bytes in our multigigabyte world these days ;)

Thanks

Zdenek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: svnfaad4.diff
Type: application/octet-stream
Size: 803 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080124/5cfc289d/attachment.obj>