[FFmpeg-devel] [PATCH] attachments support in matroska demuxer

[Reimar Döffinger]

Hello,
On Sun, Jan 20, 2008 at 03:42:09AM +0100, Michael Niedermayer wrote:
[...]
> > > iam against some undocumented char *type
> > > please document precissely what it repressents and how it differs from
> > > codec_tag, stream_codec_tag and codec_id
> > > or even better get rid of it and use codec_tag or explain why the type
> > > here should be special cased relative to these funny codec id strings in
> > > matroska
> > 
> > Currently, *type stores the standard mime type of the attachment.
> 
> so it idetifies what the attachment is ...
> thats what codec_tag does alraedy ...

Sorry to be so flameish, but no, maybe codec_id does that, but codec_tag
certainly does not. E.g. for mp4 files all kind of audio has mp4a as
codec_tag and some other things like that.

Greetings,
Reimar D?ffinger