[FFmpeg-devel] [Patch] Behaviour of liba52 decoder

[Diego Biurrun]

On Fri, Jan 11, 2008 at 08:40:51AM +0100, Thorsten Jordan wrote:
> Michael Niedermayer schrieb:
> > On Thu, Jan 10, 2008 at 02:00:24PM +0100, Thorsten Jordan wrote:
> >> Ivo schrieb:
> >>> On Thursday 10 January 2008 13:24, Thorsten Jordan wrote:
> >>>> Michael Niedermayer schrieb:
> >> +    if (buf_size < len) {
> >> +        av_log(avctx, AV_LOG_ERROR, "Error decoding frame, not enough bytes\n");
> >> +        return -1;
> >> +    }
> > 
> > Please move this check before setting anything like the sample_rate.
> > A packet of the wrong size is not convincing in terms of carring correct
> > sample_rate, channels, ... information
> 
> Thank you for your feedback.
> 
> I can fix the patch, but would it be of interest, if the liba52-wrapper
> would get removed soon?

I think yes.  It is not yet sure if the liba52 wrapper will be removed
and even then it would be preferable to have a version with less bugs so
that it works better in comparisons.

Diego