[FFmpeg-devel] [PATCH] move avc sps/pps generation in a function in movenc

[Aurelien Jacobs]

Aurelien Jacobs wrote:

> Baptiste Coudurier wrote:
> 
> > Hi,
> > 
> > Aurelien Jacobs wrote:
> > 
> > > So, now, do you think the patch is OK, and do you want me to
> > > rename the function to isom_write_avcc or not ?
> > 
> > Yes, parts are OK, checking return value for avc_parse_nal_units
> > (both cases),
> 
> Will do.
> 
> > then to correctly split parts in commits IMHO, extract
> > isom_write_avcc function, and then change prototype of
> > avc_parse_nal_units.
> 
> Unfortunately, I can't use current avc_parse_nal_units prototype
> along with my definition of isom_write_avcc. So I would also need
> to change avc_parse_nal_units prototype (and code) later. That's
> not very nice, and IMO overkill. So I guess I will commit
> avc_parse_nal_units prototype change along with isom_write_avcc
> function extraction.

I finally applied it in part, by first changing avc_parse_nal_units
prototype, and then extracting isom_write_avcc.

Aurel