[FFmpeg-devel] [PATCH] Make AVRtpPayloadTypes static and constant

[Aurelien Jacobs]

Luca Abeni wrote:

> Hi Michael,
> 
> Michael Niedermayer wrote:
> [...]
> >>> And rtp.h should not be installed IIRC
> >>> And any application depending on anything from it is broken, this
> >>> stuff is not part of the public API IMHO
> > 
> >> Some months ago I proposed to avoid installing rtp.h, and I was
> >> told that it is needed.
> 
> See the thread with subject "Why is rtp.h installed?" on ffmpeg-devel
> (started on 10/26/2007).
> 
> 
> > Needed by what?
> 
> Right now, it's only needed by ffserver.c. But ffserver.c also
> includes config.h, so it is not a reason for installing rtp.h.
> Maybe some applications might need rtp_get_local_port() (and/or
> rtp_get_file_handles()?), but I am not sure...
> 
> So, I'd like to remove rtp.h from the installed headers. BTW, I
> committed the patch, and Aurelien replied saying that the commit is
> breaking API and ABI. So, we should discuss about this issue and
> decide if rtp.h is part of the API or not.

Note that I replied to the commit before reading this thread.
And if you want my opinion, just drop rtp.h out of installed headers
right now.

Aurel