[FFmpeg-devel] [PATCH] Make AVRtpPayloadTypes static and constant

[Michael Niedermayer]

On Sat, Jan 05, 2008 at 02:38:34PM +0100, Luca Abeni wrote:
> On Sat, 2008-01-05 at 14:19 +0100, Luca Abeni wrote:
> > On Sat, 2008-01-05 at 13:34 +0100, Diego 'Flameeyes' Petten? wrote:
> > > The attached patch changes the way AVRtpPayloadTypes is defined.
> > [...]
> > 
> > I'm all in favour of this change
> 
> Double thinking about it, I have some doubts about the "const" part. I
> agree that right now AVRtpPayloadTypes is not modified by ffmpeg's code,
> but I suspect that if rtp_get_payload_type() does not find a PT and a
> dynamic PT is used, then the corresponding entry in AVRtpPayloadTypes
> should be modified... Otherwise, there is no point in having the entries
> > 35 in the table.

It is absolutely not possible to change any entry in any global or static
table. This would totally break multithreaded apps.
That said, the table should be const. If the type is const or not as another
question.

And rtp.h should not be installed IIRC
And any application depending on anything from it is broken, this stuff is
not part of the public API IMHO


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080105/752f6994/attachment.pgp>