[FFmpeg-devel] MPEG-PS demuxer index memory usage

[Paul Kelly]

On Fri, 4 Jan 2008, Paul Kelly wrote:

> While looking at av_add_index_entry() in depth
[...]

I've come across something (see memmove() usage in attached patch) that 
looks very much to me like a bug - I find it hard to believe such a bug 
could have existed for so long but I know I'm going to waste hours 
rationalising it to myself if I don't dump it here now so apologies if I'm 
wasting the list's time...

Basically the memmove() looks to me like it's only shifting the array of 
index entries up by 1 byte but then inserting a whole AVIndexEntry, 
resulting in corruption of the index table.

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: av_add_index_entry.diff
Type: text/x-diff
Size: 721 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080104/4dfa85ed/attachment.diff>