[FFmpeg-devel] h264 crash in decode_residual

[Gadi Bergman]

Hi,
 
I have sent you a sample file. The mailing list responded that my message was too big.
I have tried extending coeff_token_table_index with more 3's for a size of 32. That stopped the crash, but I'm not sure whether this is the right fix to this problem.
 
Gadi> Date: Wed, 2 Jan 2008 08:45:51 +0100> From: banan at ludd.ltu.se> To: ffmpeg-devel at mplayerhq.hu> Subject: Re: [FFmpeg-devel] h264 crash in decode_residual> > Hi,> > Gadi Bergman wrote:> > Hello Michael, team members and readers,> > I am decoding streams generated by an h264 proprietary encoder using FFMPEG h264 decoder from MPlayer 1.0rc1.> > I get often a crash in function decode_residual:> > static int decode_residual(H264Context *h, GetBitContext *gb, DCTELEM *block, int n, const uint8_t *scantable, const uint32_t *qmul, int max_coeff){> > MpegEncContext * const s = &h->s;> > static const int coeff_token_table_index[17]= {0, 0, 1, 1, 2, 2, 2, 2, 3, 3, 3, 3, 3, 3, 3, 3, 3};> > int level[16];> > int zeros_left, coeff_num, coeff_token, total_coeff, i, j, trailing_ones, run_before;> > if(n == CHROMA_DC_BLOCK_INDEX){> > coeff_token= get_vlc2(gb, chroma_dc_coeff_token_vlc.table, CHROMA_DC_COEFF_TOKEN_VLC_BITS, 1);> > total_coeff= coeff_token>>2;> > }else{> > if(n == LUMA_DC_BLOCK_INDEX){> > total_coeff= pred_non_zero_count(h, 0);> > coeff_token= get_vlc2(gb, coeff_token_vlc[ coeff_token_table_index[total_coeff] ].table, COEFF_TOKEN_VLC_BITS, 2);> > total_coeff= coeff_token>>2;> > }else{> > total_coeff= pred_non_zero_count(h, n);> >> > /* here I get total_coeff == 31 */> > /* coeff_token_table_index[total_coeff] is not not defined for this index */> > /* I get a crash in the next line */> >> > coeff_token= get_vlc2(gb, coeff_token_vlc[ coeff_token_table_index[total_coeff] ].table, COEFF_TOKEN_VLC_BITS, 2);> > total_coeff= coeff_token>>2;> > h->non_zero_count_cache[ scan8[n] ]= total_coeff;> > }> > }> > Any recommendations?> > Should I extend coeff_token_table_index with more 3's for a size of 32 ?> > Thanks,> > Gadi> > > please provide a sample so we can reproduce this crash with current FFmpeg.> > MvH> Benjamin Larsson> > > _______________________________________________> ffmpeg-devel mailing list> ffmpeg-devel at mplayerhq.hu> http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
_________________________________________________________________
The best games are on Xbox 360.  Click here for a special offer on an Xbox 360 Console.
http://www.xbox.com/en-US/hardware/wheretobuy/